• Peter Zijlstra's avatar
    perf: Fix perf_event_exit_task() race · 63b6da39
    Peter Zijlstra authored
    There is a race against perf_event_exit_task() vs
    event_function_call(),find_get_context(),perf_install_in_context()
    (iow, everyone).
    
    Since there is no permanent marker on a context that its dead, it is
    quite possible that we access (and even modify) a context after its
    passed through perf_event_exit_task().
    
    For instance, find_get_context() might find the context still
    installed, but by the time we get to perf_install_in_context() it
    might already have passed through perf_event_exit_task() and be
    considered dead, we will however still add the event to it.
    
    Solve this by marking a ctx dead by setting its ctx->task value to -1,
    it must be !0 so we still know its a (former) task context.
    Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
    Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
    Cc: David Ahern <dsahern@gmail.com>
    Cc: Jiri Olsa <jolsa@redhat.com>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Stephane Eranian <eranian@google.com>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: Vince Weaver <vincent.weaver@maine.edu>
    Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
    63b6da39
core.c 220 KB