• Sean Christopherson's avatar
    KVM: x86: Alert userspace that KVM_SET_CPUID{,2} after KVM_RUN is broken · 63f5a190
    Sean Christopherson authored
    Warn userspace that KVM_SET_CPUID{,2} after KVM_RUN "may" cause guest
    instability.  Initialize last_vmentry_cpu to -1 and use it to detect if
    the vCPU has been run at least once when its CPUID model is changed.
    
    KVM does not correctly handle changes to paging related settings in the
    guest's vCPU model after KVM_RUN, e.g. MAXPHYADDR, GBPAGES, etc...  KVM
    could theoretically zap all shadow pages, but actually making that happen
    is a mess due to lock inversion (vcpu->mutex is held).  And even then,
    updating paging settings on the fly would only work if all vCPUs are
    stopped, updated in concert with identical settings, then restarted.
    
    To support running vCPUs with different vCPU models (that affect paging),
    KVM would need to track all relevant information in kvm_mmu_page_role.
    Note, that's the _page_ role, not the full mmu_role.  Updating mmu_role
    isn't sufficient as a vCPU can reuse a shadow page translation that was
    created by a vCPU with different settings and thus completely skip the
    reserved bit checks (that are tied to CPUID).
    
    Tracking CPUID state in kvm_mmu_page_role is _extremely_ undesirable as
    it would require doubling gfn_track from a u16 to a u32, i.e. would
    increase KVM's memory footprint by 2 bytes for every 4kb of guest memory.
    E.g. MAXPHYADDR (6 bits), GBPAGES, AMD vs. INTEL = 1 bit, and SEV C-BIT
    would all need to be tracked.
    
    In practice, there is no remotely sane use case for changing any paging
    related CPUID entries on the fly, so just sweep it under the rug (after
    yelling at userspace).
    Signed-off-by: default avatarSean Christopherson <seanjc@google.com>
    Message-Id: <20210622175739.3610207-8-seanjc@google.com>
    Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    63f5a190
x86.c 321 KB