• Martin Jocic's avatar
    can: kvaser_pciefd: Use a single write when releasing RX buffers · dd885d90
    Martin Jocic authored
    Kvaser's PCIe cards uses the KCAN FPGA IP block which has dual 4K
    buffers for incoming messages shared by all (currently up to eight)
    channels. While the driver processes messages in one buffer, new
    incoming messages are stored in the other and so on.
    
    The design of KCAN is such that a buffer must be fully read and then
    released. Releasing a buffer will make the FPGA switch buffers. If the
    other buffer contains at least one incoming message the FPGA will also
    instantly issue a new interrupt, if not the interrupt will be issued
    after receiving the first new message.
    
    With IRQx interrupts, it takes a little time for the interrupt to
    happen, enough for any previous ISR call to do it's business and
    return, but MSI interrupts are way faster so this time is reduced to
    almost nothing.
    
    So with MSI, releasing the buffer HAS to be the very last action of
    the ISR before returning, otherwise the new interrupt might be
    "masked" by the kernel because the previous ISR call hasn't returned.
    And the interrupts are edge-triggered so we cannot loose one, or the
    ping-pong reading process will stop.
    
    This is why this patch modifies the driver to use a single write to
    the SRB_CMD register before returning.
    Signed-off-by: default avatarMartin Jocic <martin.jocic@kvaser.com>
    Reviewed-by: default avatarVincent Mailhol <mailhol.vincent@wanadoo.fr>
    Link: https://patch.msgid.link/20240830153113.2081440-1-martin.jocic@kvaser.com
    Fixes: 26ad340e ("can: kvaser_pciefd: Add driver for Kvaser PCIEcan devices")
    Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
    dd885d90
kvaser_pciefd.c 55.5 KB