• Waiman Long's avatar
    fs/proc/proc_sysctl.c: fix typo in sysctl_check_table_array() · 64a11f3d
    Waiman Long authored
    Patch series "ipc: Clamp *mni to the real IPCMNI limit", v3.
    
    The sysctl parameters msgmni, shmmni and semmni have an inherent limit
    of IPC_MNI (32k).  However, users may not be aware of that because they
    can write a value much higher than that without getting any error or
    notification.  Reading the parameters back will show the newly written
    values which are not real.
    
    Enforcing the limit by failing sysctl parameter write, however, can
    break existing user applications.  To address this delemma, a new flags
    field is introduced into the ctl_table.  The value CTL_FLAGS_CLAMP_RANGE
    can be added to any ctl_table entries to enable a looser range clamping
    without returning any error.  For example,
    
      .flags = CTL_FLAGS_CLAMP_RANGE,
    
    This flags value are now used for the range checking of shmmni, msgmni
    and semmni without breaking existing applications.  If any out of range
    value is written to those sysctl parameters, the following warning will
    be printed instead.
    
      Kernel parameter "shmmni" was set out of range [0, 32768], clamped to 32768.
    
    Reading the values back will show 32768 instead of some fake values.
    
    This patch (of 6):
    
    Fix a typo.
    
    Link: http://lkml.kernel.org/r/1519926220-7453-2-git-send-email-longman@redhat.comSigned-off-by: default avatarWaiman Long <longman@redhat.com>
    Reviewed-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Acked-by: default avatarLuis R. Rodriguez <mcgrof@kernel.org>
    Cc: Davidlohr Bueso <dave@stgolabs.net>
    Cc: Manfred Spraul <manfred@colorfullife.com>
    Cc: Kees Cook <keescook@chromium.org>
    Cc: Al Viro <viro@zeniv.linux.org.uk>
    Cc: Matthew Wilcox <willy@infradead.org>
    Cc: Randy Dunlap <rdunlap@infradead.org>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    64a11f3d
proc_sysctl.c 40.8 KB