Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • L linux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Kirill Smelkov
  • linux
  • Repository
You need to sign in or sign up before continuing.
  • linux
  • lib
  • kunit
  • executor.c
Find file BlameHistoryPermalink
  • Daniel Latypov's avatar
    kunit: fix executor OOM error handling logic on non-UML · 1b11063d
    Daniel Latypov authored May 13, 2022
    The existing logic happens to work fine on UML, but is not correct when
    running on other arches.
    
    1. We didn't initialize `int err`, and kunit_filter_suites() doesn't
       explicitly set it to 0 on success. So we had false "failures".
       Note: it doesn't happen on UML, causing this to get overlooked.
    2. If we error out, we do not call kunit_handle_shutdown().
       This makes kunit.py timeout when using a non-UML arch, since the QEMU
       process doesn't ever exit.
    
    Fixes: a02353f4
    
     ("kunit: bail out of test filtering logic quicker if OOM")
    Signed-off-by: default avatarDaniel Latypov <dlatypov@google.com>
    Reviewed-by: default avatarBrendan Higgins <brendanhiggins@google.com>
    Signed-off-by: default avatarShuah Khan <skhan@linuxfoundation.org>
    1b11063d
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7