• Anton Vorontsov's avatar
    powerpc: Make it possible to select hibernation on all PowerPCs · 64eb38a6
    Anton Vorontsov authored
    Just as with kexec, hibernation may fail even on well-tested platforms:
    some PCI device, a driver of which doesn't play well with hibernation,
    is enough to break resuming.
    
    Hibernation code is not much platform dependent, and hiding features only
    because these were not verified on a particular hardware is
    counterproductive: we just prevent the features from being widely tested.
    
    For example, with this patch I just tested hibernation on a MPC83xx
    board, and it works quite well, modulo a few drivers that need some
    fixing.
    
    So, let's make it possible to select hibernation support for all
    PowerPCs, then let's wait for any possible bug reports, and actually fix
    (or just collect ;-) the bugs instead of hiding them. If some platforms
    really can't stand hibernation, we can make a blacklist, with proper
    comments why exactly hibernation doesn't work, whether it is possible to
    fix, and what needs to be done to fix it.
    
    CONFIG_HIBERNATION is still =n by default, so the commit doesn't change
    anything apart from ability to set it to =y.
    
    I'm not sure if EXPERIMENTAL dependency is needed, I'd rather not add it
    for a few reasons:
    
    1) It doesn't matter much, for distro kernels user has no clue that some
       feature is experimental. Majority of defconfigs enable EXPERIMENTAL
       anyway (90 vs. 4, which, btw, means that EXPERIMENTAL is overused
       in Kconfigs);
    
    2) EXPERIMENTAL is a good thing for features that change default
       behaviour of a kernel, while for hibernation user has to explicitly
       issue 'echo disk > /sys/power/state' to trigger any hibernation bugs;
    
    3) Per init/Kconfig, EXPERIMENTAL is a good thing to scare and discourage
       users from 'widespread use of a feature', while we want to encourage
       that use.
    Signed-off-by: default avatarAnton Vorontsov <avorontsov@ru.mvista.com>
    Signed-off-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
    64eb38a6
Kconfig 23.4 KB