• Tom Rix's avatar
    ALSA: hda/cs8409: change cs8409_fixups v.pins initializers to static · 65123b89
    Tom Rix authored
    sparse reports
    sound/pci/hda/patch_cs8409-tables.c:79:25: warning: symbol 'cs8409_cs42l42_pincfgs_no_dmic' was not declared. Should it be static?
    
    cs8409_cs42l42_pincfgs_no_dmic is only used by cs8409_fixups table as an
    initializer for the hda_fixup element v.pins.  Both are defined in the
    patch_cs8408-table.c file but only cs8409_fixups is used externally in
    patch_cs8409.c.  So cs8409_cs42l42_pincfgs_no_dmic should have a static
    storage class specifier.
    
    The other v.pins initializers in cs8409_fixups table, though declared
    extern in patch_cs8409.h are also only used in patch_cs8409-tables.c.
    So change all the v.pins initializers to static.
    
    Fixes: 9e7647b5 ("ALSA: hda/cs8409: Move arrays of configuration to a new file")
    Signed-off-by: default avatarTom Rix <trix@redhat.com>
    Link: https://lore.kernel.org/r/20220704142836.636204-1-trix@redhat.comSigned-off-by: default avatarTakashi Iwai <tiwai@suse.de>
    65123b89
patch_cs8409-tables.c 24 KB