• Andrew Price's avatar
    gfs2: Add a next-resource-group pointer to resource groups · 65adc273
    Andrew Price authored
    Add a new rg_skip field to struct gfs2_rgrp, replacing __pad. The
    rg_skip field has the following meaning:
    
    - If rg_skip is zero, it is considered unset and not useful.
    - If rg_skip is non-zero, its value will be the number of blocks between
      this rgrp's address and the next rgrp's address. This can be used as a
      hint by fsck.gfs2 when rebuilding a bad rindex, for example.
    
    This will provide less dependency on the rindex in future, and allow
    tools such as fsck.gfs2 to iterate the resource groups without keeping
    the rindex around.
    
    The field is updated in gfs2_rgrp_out() so that existing file systems
    will have it set. This means that any resource groups that aren't ever
    written will not be updated. The final rgrp is a special case as there
    is no next rgrp, so it will always have a rg_skip of 0 (unless the fs is
    extended).
    
    Before this patch, gfs2_rgrp_out() zeroes the __pad field explicitly, so
    the rg_skip field can get set back to 0 in cases where nodes with and
    without this patch are mixed in a cluster. In some cases, the field may
    bounce between being set by one node and then zeroed by another which
    may harm performance slightly, e.g. when two nodes create many small
    files. In testing this situation is rare but it becomes more likely as
    the filesystem fills up and there are fewer resource groups to choose
    from. The problem goes away when all nodes are running with this patch.
    Dipping into the space currently occupied by the rg_reserved field would
    have resulted in the same problem as it is also explicitly zeroed, so
    unfortunately there is no other way around it.
    Signed-off-by: default avatarAndrew Price <anprice@redhat.com>
    Signed-off-by: default avatarBob Peterson <rpeterso@redhat.com>
    65adc273
rgrp.c 68.4 KB