• Stephen Hemminger's avatar
    sky2: irqname based on pci address · 66466797
    Stephen Hemminger authored
    This is based on Michal Schmidt fix for skge.
    
    Most network drivers request their IRQ when the interface is activated.
    sky2 does it in ->probe() instead, because it can work with two-port
    cards where the two net_devices use the same IRQ. This works fine most
    of the time, except in some situations when the interface gets renamed.
    Consider this example:
    
    1. modprobe sky2
       The card is detected as eth0 and requests IRQ 17. Directory
       /proc/irq/17/eth0 is created.
    2. There is an udev rule which says this interface should be called
       eth1, so udev renames eth0 -> eth1.
    3. modprobe 8139too
       The Realtek card is detected as eth0. It will be using IRQ 17 too.
    4. ip link set eth0 up
       Now 8139too requests IRQ 17.
    
    The result is:
    WARNING: at fs/proc/generic.c:590 proc_register ...
    proc_dir_entry '17/eth0' already registered
    
    The fix is for sky2 to name the irq based on the pci device, as is done
    by some other devices DRM, infiniband, ...  ie. sky2@pci:0000:00:00
    Signed-off-by: default avatarStephen Hemminger <shemminger@vyatta.com>
    Reviewed-by: default avatarMichal Schmidt <mschmidt@redhat.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    66466797
sky2.h 80 KB