• Linus Torvalds's avatar
    [AGP] Allocate AGP pages with GFP_DMA32 by default · 66c669ba
    Linus Torvalds authored
    Not all graphic page remappers support physical addresses over the 4GB
    mark for remapping, so while some do (the AMD64 GART always did, and I
    just fixed the i965 to do so properly), we're safest off just forcing
    GFP_DMA32 allocations to make sure graphics pages get allocated in the
    low 32-bit address space by default.
    
    AGP sub-drivers that really care, and can do better, could just choose
    to implement their own allocator (or we could add another "64-bit safe"
    default allocator for their use), but quite frankly, you're not likely
    to care in practice.
    
    So for now, this trivial change means that we won't be allocating pages
    that we can't map correctly by mistake on x86-64.
    
    [ On traditional 32-bit x86, this could never happen, because GFP_KERNEL
      would never allocate any highmem memory anyway ]
    Acked-by: default avatarAndi Kleen <ak@suse.de>
    Acked-by: default avatarDave Jones <davej@redhat.com>
    Cc: Eric Anholt <eric@anholt.net>
    Cc: Keith Packard <keithp@keithp.com>
    Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
    66c669ba
generic.c 31.7 KB