• Mathias Krause's avatar
    drm/i915: Remove bogus __init annotation from DMI callbacks · 6760b986
    Mathias Krause authored
    commit bbe1c274 upstream.
    
    The __init annotations for the DMI callback functions are wrong as this
    code can be called even after the module has been initialized, e.g. like
    this:
    
      # echo 1 > /sys/bus/pci/devices/0000:00:02.0/remove
      # modprobe i915
      # echo 1 > /sys/bus/pci/rescan
    
    The first command will remove the PCI device from the kernel's device
    list so the second command won't see it right away. But as it registers
    a PCI driver it'll see it on the third command. If the system happens to
    match one of the DMI table entries we'll try to call a function in long
    released memory and generate an Oops, at best.
    
    Fix this by removing the bogus annotation.
    
    Modpost should have caught that one but it ignores section reference
    mismatches from the .rodata section. :/
    
    Fixes: 25e341cf ("drm/i915: quirk away broken OpRegion VBT")
    Fixes: 8ca4013d ("CHROMIUM: i915: Add DMI override to skip CRT...")
    Fixes: 425d244c ("drm/i915: ignore LVDS on intel graphics systems...")
    Signed-off-by: default avatarMathias Krause <minipli@googlemail.com>
    Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
    Cc: Duncan Laurie <dlaurie@chromium.org>
    Cc: Jarod Wilson <jarod@redhat.com>
    Cc: Rusty Russell <rusty@rustcorp.com.au>	# Can modpost be fixed?
    Signed-off-by: default avatarJani Nikula <jani.nikula@intel.com>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    6760b986
intel_bios.c 34.9 KB