• Enrico Weigelt, metux IT consult's avatar
    nvmet: include <linux/scatterlist.h> · a5dffbb6
    Enrico Weigelt, metux IT consult authored
    Build breaks:
    
        drivers/nvme/target/core.c: In function 'nvmet_req_alloc_sgl':
        drivers/nvme/target/core.c:939:12: error: implicit declaration of \
    function 'sgl_alloc'; did you mean 'bio_alloc'? \
    [-Werror=implicit-function-declaration]
          req->sg = sgl_alloc(req->transfer_len, GFP_KERNEL, &req->sg_cnt);
                    ^~~~~~~~~
                    bio_alloc
        drivers/nvme/target/core.c:939:10: warning: assignment makes pointer \
    from integer without a cast [-Wint-conversion]
          req->sg = sgl_alloc(req->transfer_len, GFP_KERNEL, &req->sg_cnt);
                  ^
        drivers/nvme/target/core.c: In function 'nvmet_req_free_sgl':
        drivers/nvme/target/core.c:952:3: error: implicit declaration of \
    function 'sgl_free'; did you mean 'ida_free'? [-Werror=implicit-function-declaration]
           sgl_free(req->sg);
           ^~~~~~~~
           ida_free
    
    Cause:
    
        1. missing include to <linux/scatterlist.h>
        2. SGL_ALLOC needs to be enabled
    
    Therefore adding the missing include, as well as Kconfig dependency.
    Signed-off-by: default avatarEnrico Weigelt, metux IT consult <info@metux.net>
    Reviewed-by: default avatarSagi Grimberg <sagi@grimberg.me>
    Reviewed-by: default avatarMinwoo Im <minwoo.im@samsung.com>
    Reviewed-by: default avatarChaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
    Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
    a5dffbb6
core.c 34.7 KB