• Ingo Molnar's avatar
    x86/fpu: Improve the initialization logic of 'err' around xstate_fault() constraints · 685c9616
    Ingo Molnar authored
    There's a confusing aspect of how xstate_fault() constraints are
    handled by the FPU register/memory copying functions in
    fpu/internal.h: they use "0" (0) to signal that the asm code
    will not always set 'err' to a valid value.
    
    But 'err' is already initialized to 0 in C code, which is duplicated
    by the asm() constraint. Should the initialization value ever be
    changed, it might become subtly inconsistent with the not too clear
    asm() constraint.
    
    Use 'err' as the value of the input variable instead, to clarify
    this all.
    
    Cc: Andy Lutomirski <luto@amacapital.net>
    Cc: Borislav Petkov <bp@alien8.de>
    Cc: Dave Hansen <dave.hansen@linux.intel.com>
    Cc: Fenghua Yu <fenghua.yu@intel.com>
    Cc: H. Peter Anvin <hpa@zytor.com>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Oleg Nesterov <oleg@redhat.com>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: linux-kernel@vger.kernel.org
    Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
    685c9616
internal.h 17.2 KB