• Aaron Conole's avatar
    net: openvswitch: limit the number of recursions from action sets · 6e2f90d3
    Aaron Conole authored
    The ovs module allows for some actions to recursively contain an action
    list for complex scenarios, such as sampling, checking lengths, etc.
    When these actions are copied into the internal flow table, they are
    evaluated to validate that such actions make sense, and these calls
    happen recursively.
    
    The ovs-vswitchd userspace won't emit more than 16 recursion levels
    deep.  However, the module has no such limit and will happily accept
    limits larger than 16 levels nested.  Prevent this by tracking the
    number of recursions happening and manually limiting it to 16 levels
    nested.
    
    The initial implementation of the sample action would track this depth
    and prevent more than 3 levels of recursion, but this was removed to
    support the clone use case, rather than limited at the current userspace
    limit.
    
    Fixes: 798c1661
    
     ("openvswitch: Optimize sample action for the clone use cases")
    Signed-off-by: default avatarAaron Conole <aconole@redhat.com>
    Reviewed-by: default avatarSimon Horman <horms@kernel.org>
    Link: https://lore.kernel.org/r/20240207132416.1488485-2-aconole@redhat.com
    
    Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
    6e2f90d3
flow_netlink.c 100 KB