• Yuan Can's avatar
    media: amphion: Fix error handling in vpu_driver_init() · 6b8c5e4b
    Yuan Can authored
    A problem about modprobe amphion-vpu failed is triggered with the
    following log given:
    
     [ 2208.634841] Error: Driver 'amphion-vpu' is already registered, aborting...
     modprobe: ERROR: could not insert 'amphion_vpu': Device or resource busy
    
    The reason is that vpu_driver_init() returns vpu_core_driver_init()
    directly without checking its return value, if vpu_core_driver_init()
    failed, it returns without unregister amphion_vpu_driver, resulting the
    amphion-vpu can never be installed later.
    A simple call graph is shown as below:
    
     vpu_driver_init()
       platform_driver_register() # register amphion_vpu_driver
       vpu_core_driver_init()
         platform_driver_register()
           driver_register()
             bus_add_driver()
               dev = kzalloc(...) # OOM happened
       # return without unregister amphion_vpu_driver
    
    Fix by unregister amphion_vpu_driver when vpu_core_driver_init() returns
    error.
    
    Fixes: b50a64fc ("media: amphion: add amphion vpu device driver")
    Signed-off-by: default avatarYuan Can <yuancan@huawei.com>
    Reviewed-by: default avatarming_qian <ming.qian@nxp.com>
    Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
    Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
    6b8c5e4b
vpu_drv.c 5.89 KB