• Nicolin Chen's avatar
    ASoC: fsl_sarc_dma: Check pair before using it · 6ccf62c7
    Nicolin Chen authored
    The patch 3117bb31: "ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and
    platform drivers" from Jul 29, 2014, leads to the following Smatch
    complaint:
    
    sound/soc/fsl/fsl_asrc_dma.c:304 fsl_asrc_dma_shutdown()
    warn: variable dereferenced before check 'pair' (see line 302)
    
    sound/soc/fsl/fsl_asrc_dma.c
    301          struct fsl_asrc_pair *pair = runtime->private_data;
    302          struct fsl_asrc *asrc_priv = pair->asrc_priv;
                                              ^^^^^^^^^^^^^^^
                                                Dereference.
    
    303
    304          if (pair && asrc_priv->pair[pair->index] == pair)
                     ^^^^
                    Check.
    
    305                  asrc_priv->pair[pair->index] = NULL;
    306
    
    So we just let the driver check pair before using it.
    Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: default avatarNicolin Chen <nicoleotsuka@gmail.com>
    Signed-off-by: default avatarMark Brown <broonie@linaro.org>
    6ccf62c7
fsl_asrc_dma.c 10.7 KB