• Filipe Manana's avatar
    btrfs: use a single argument for extent offset in backref walking functions · 6ce6ba53
    Filipe Manana authored
    The interface for find_parent_nodes() has two extent offset related
    arguments:
    
    1) One u64 pointer argument for the extent offset;
    
    2) One boolean argument to tell if the extent offset should be ignored or
       not.
    
    These are confusing, becase the extent offset pointer can be NULL and in
    some cases callers pass a NULL value as a way to tell the backref walking
    code to ignore offsets in file extent items (and simply consider all file
    extent items that point to the target data extent).
    
    The boolean argument was added in commit c995ab3c ("btrfs: add a flag
    to iterate_inodes_from_logical to find all extent refs for uncompressed
    extents"), but it was never really necessary, it was enough if it could
    find a way to get a NULL value passed to the "extent_item_pos" argument of
    find_parent_nodes(). The arguments are also passed to functions called
    by find_parent_nodes() and respective helper functions, which further
    makes everything more complicated than needed.
    
    Then we have several backref walking related functions that end up calling
    find_parent_nodes(), either directly or through some other function that
    they call, and for many we have to use an "extent_item_pos" (u64) argument
    and a boolean "ignore_offset" argument too.
    
    This is confusing and not really necessary. So use a single argument to
    specify the extent offset, as a simple u64 and not as a pointer, but
    using a special value of (u64)-1, defined as a documented constant, to
    indicate when the extent offset should be ignored.
    
    This is also preparation work for the upcoming patches in the series that
    add other arguments to find_parent_nodes() and other related functions
    that use it.
    Signed-off-by: default avatarFilipe Manana <fdmanana@suse.com>
    Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
    6ce6ba53
relocation.c 114 KB