• Uros Bizjak's avatar
    bpf: Fix percpu address space issues · 6d641ca5
    Uros Bizjak authored
    In arraymap.c:
    
    In bpf_array_map_seq_start() and bpf_array_map_seq_next()
    cast return values from the __percpu address space to
    the generic address space via uintptr_t [1].
    
    Correct the declaration of pptr pointer in __bpf_array_map_seq_show()
    to void __percpu * and cast the value from the generic address
    space to the __percpu address space via uintptr_t [1].
    
    In hashtab.c:
    
    Assign the return value from bpf_mem_cache_alloc() to void pointer
    and cast the value to void __percpu ** (void pointer to percpu void
    pointer) before dereferencing.
    
    In memalloc.c:
    
    Explicitly declare __percpu variables.
    
    Cast obj to void __percpu **.
    
    In helpers.c:
    
    Cast ptr in BPF_CALL_1 and BPF_CALL_2 from generic address space
    to __percpu address space via const uintptr_t [1].
    
    Found by GCC's named address space checks.
    
    There were no changes in the resulting object files.
    
    [1] https://sparse.docs.kernel.org/en/latest/annotations.html#address-space-nameSigned-off-by: default avatarUros Bizjak <ubizjak@gmail.com>
    Cc: Alexei Starovoitov <ast@kernel.org>
    Cc: Daniel Borkmann <daniel@iogearbox.net>
    Cc: Andrii Nakryiko <andrii@kernel.org>
    Cc: Martin KaFai Lau <martin.lau@linux.dev>
    Cc: Eduard Zingerman <eddyz87@gmail.com>
    Cc: Song Liu <song@kernel.org>
    Cc: Yonghong Song <yonghong.song@linux.dev>
    Cc: John Fastabend <john.fastabend@gmail.com>
    Cc: KP Singh <kpsingh@kernel.org>
    Cc: Stanislav Fomichev <sdf@fomichev.me>
    Cc: Hao Luo <haoluo@google.com>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Acked-by: default avatarEduard Zingerman <eddyz87@gmail.com>
    Link: https://lore.kernel.org/r/20240811161414.56744-1-ubizjak@gmail.comSigned-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
    6d641ca5
memalloc.c 26.4 KB