• Lv Yunlong's avatar
    net:emac/emac-mac: Fix a use after free in emac_mac_tx_buf_send · 6d72e7c7
    Lv Yunlong authored
    In emac_mac_tx_buf_send, it calls emac_tx_fill_tpd(..,skb,..).
    If some error happens in emac_tx_fill_tpd(), the skb will be freed via
    dev_kfree_skb(skb) in error branch of emac_tx_fill_tpd().
    But the freed skb is still used via skb->len by netdev_sent_queue(,skb->len).
    
    As i observed that emac_tx_fill_tpd() haven't modified the value of skb->len,
    thus my patch assigns skb->len to 'len' before the possible free and
    use 'len' instead of skb->len later.
    
    Fixes: b9b17deb ("net: emac: emac gigabit ethernet controller driver")
    Signed-off-by: default avatarLv Yunlong <lyl2019@mail.ustc.edu.cn>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    6d72e7c7
emac-mac.c 43.4 KB