• Hans de Goede's avatar
    media: i2c: ov8865: Fix lockdep error · 6e1c9bc9
    Hans de Goede authored
    ov8865_state_init() calls ov8865_state_mipi_configure() which uses
    __v4l2_ctrl_s_ctrl[_int64](). This means that sensor->mutex (which
    is also sensor->ctrls.handler.lock) must be locked before calling
    ov8865_state_init().
    
    Note ov8865_state_mipi_configure() is also used in other places where
    the lock is already held so it cannot be changed itself.
    
    This fixes the following lockdep kernel WARN:
    
    [   13.233421] WARNING: CPU: 0 PID: 8 at drivers/media/v4l2-core/v4l2-ctrls-api.c:833 __v4l2_ctrl_s_ctrl+0x4d/0x60 [videodev]
    ...
    [   13.234063] Call Trace:
    [   13.234074]  ov8865_state_configure+0x98b/0xc00 [ov8865]
    [   13.234095]  ov8865_probe+0x4b1/0x54c [ov8865]
    [   13.234117]  i2c_device_probe+0x13c/0x2d0
    
    Fixes: 11c0d8fd ("media: i2c: Add support for the OV8865 image sensor")
    Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
    Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
    Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
    6e1c9bc9
ov8865.c 74.4 KB