• Chuck Lever's avatar
    SUNRPC: Clean up bc_svc_process() · 6ed8cdf9
    Chuck Lever authored
    The test robot complained that, in some build configurations, the
    @error variable in bc_svc_process's only caller is set but never
    used. This happens because dprintk() is the only consumer of that
    value.
    
     - Remove the dprintk() call sites in favor of the svc_process
       tracepoint
     - The @error variable and the return value of bc_svc_process() are
       now unused, so get rid of them.
     - The @serv parameter is set to rqstp->rq_serv by the only caller,
       and bc_svc_process() then uses it only to set rqstp->rq_serv. It
       can be removed.
     - Rename bc_svc_process() according to the convention that
       globally-visible RPC server functions have names that begin with
       "svc_"; and because it is globally-visible, give it a proper
       kdoc comment.
    Reported-by: default avatarkernel test robot <lkp@intel.com>
    Closes: https://lore.kernel.org/oe-kbuild-all/202308121314.HA8Rq2XG-lkp@intel.com/Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
    6ed8cdf9
callback.c 9.79 KB