• Vladimir Oltean's avatar
    ARM: dts: ls1021a: Restore MDIO compatible to gianfar · 7155c446
    Vladimir Oltean authored
    The difference between "fsl,etsec2-mdio" and "gianfar" has to do with
    the .get_tbipa function, which calculates the address of the TBIPA
    register automatically, if not explicitly specified. [ see
    drivers/net/ethernet/freescale/fsl_pq_mdio.c ]. On LS1021A, the TBIPA
    register is at offset 0x30 within the port register block, which is what
    the "gianfar" method of calculating addresses actually does.
    
    Luckily, the bad "compatible" is inconsequential for ls1021a.dtsi,
    because the TBIPA register is explicitly specified via the second "reg"
    (<0x0 0x2d10030 0x0 0x4>), so the "get_tbipa" function is dead code.
    Nonetheless it's good to restore it to its correct value.
    
    Background discussion:
    https://www.spinics.net/lists/stable/msg361156.html
    
    Fixes: c7861adb ("ARM: dts: ls1021: Fix SGMII PCS link remaining down after PHY disconnect")
    Reported-by: default avatarPavel Machek <pavel@denx.de>
    Signed-off-by: default avatarVladimir Oltean <olteanv@gmail.com>
    Signed-off-by: default avatarShawn Guo <shawnguo@kernel.org>
    7155c446
ls1021a.dtsi 27.1 KB