• Chuck Lever's avatar
    svcrdma: Do not send XDR roundup bytes for a write chunk · 6f18dc89
    Chuck Lever authored
    Minor optimization: when dealing with write chunk XDR roundup, do
    not post a Write WR for the zero bytes in the pad. Simply update
    the write segment in the RPC-over-RDMA header to reflect the extra
    pad bytes.
    
    The Reply chunk is also a write chunk, but the server does not use
    send_write_chunks() to send the Reply chunk. That's OK in this case:
    the server Upper Layer typically marshals the Reply chunk contents
    in a single contiguous buffer, without a separate tail for the XDR
    pad.
    
    The comments and the variable naming refer to "chunks" but what is
    really meant is "segments." The existing code sends only one
    xdr_write_chunk per RPC reply.
    
    The fix assumes this as well. When the XDR pad in the first write
    chunk is reached, the assumption is the Write list is complete and
    send_write_chunks() returns.
    
    That will remain a valid assumption until the server Upper Layer can
    support multiple bulk payload results per RPC.
    Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
    Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
    6f18dc89
svc_rdma_sendto.c 18.2 KB