• Steve French's avatar
    various endian fixes to cifs · 5443d130
    Steve French authored
    make modules C=2 M=fs/cifs CF=-D__CHECK_ENDIAN__
    
    Found for example:
    
     CHECK   fs/cifs/cifssmb.c
    fs/cifs/cifssmb.c:728:22: warning: incorrect type in assignment (different base types)
    fs/cifs/cifssmb.c:728:22:    expected unsigned short [unsigned] [usertype] Tid
    fs/cifs/cifssmb.c:728:22:    got restricted __le16 [usertype] <noident>
    fs/cifs/cifssmb.c:1883:45: warning: incorrect type in assignment (different base types)
    fs/cifs/cifssmb.c:1883:45:    expected long long [signed] [usertype] fl_start
    fs/cifs/cifssmb.c:1883:45:    got restricted __le64 [usertype] start
    fs/cifs/cifssmb.c:1884:54: warning: restricted __le64 degrades to integer
    fs/cifs/cifssmb.c:1885:58: warning: restricted __le64 degrades to integer
    fs/cifs/cifssmb.c:1886:43: warning: incorrect type in assignment (different base types)
    fs/cifs/cifssmb.c:1886:43:    expected unsigned int [unsigned] fl_pid
    fs/cifs/cifssmb.c:1886:43:    got restricted __le32 [usertype] pid
    
    In checking new smb2 code for missing endian conversions, I noticed
    some endian errors had crept in over the last few releases into the
    cifs code (symlink, ntlmssp, posix lock, and also a less problematic warning
    in fscache).  A followon patch will address a few smb2 endian
    problems.
    Reviewed-by: default avatarJeff Layton <jlayton@redhat.com>
    Signed-off-by: default avatarSteve French <sfrench@us.ibm.com>
    5443d130
link.c 14.1 KB