• Eric Dumazet's avatar
    tcp: gso: do not generate out of order packets · 6ff50cd5
    Eric Dumazet authored
    GSO TCP handler has following issues :
    
    1) ooo_okay from original GSO packet is duplicated to all segments
    2) segments (but the last one) are orphaned, so transmit path can not
    get transmit queue number from the socket. This happens if GSO
    segmentation is done before stacked device for example.
    
    Result is we can send packets from a given TCP flow to different TX
    queues (if using multiqueue NICS). This generates OOO problems and
    spurious SACK & retransmits.
    
    Fix this by keeping socket pointer set for all segments.
    
    This means that every segment must also have a destructor, and the
    original gso skb truesize must be split on all segments, to keep
    precise sk->sk_wmem_alloc accounting.
    Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
    Cc: Maciej Żenczykowski <maze@google.com>
    Cc: Tom Herbert <therbert@google.com>
    Cc: Neal Cardwell <ncardwell@google.com>
    Cc: Yuchung Cheng <ycheng@google.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    6ff50cd5
tcp.c 87.6 KB