• Michael S. Tsirkin's avatar
    virtio_mmio: fix access width for mmio · 704a0b5f
    Michael S. Tsirkin authored
    Going over the virtio mmio code, I noticed that it doesn't correctly
    access modern device config values using "natural" accessors: it uses
    readb to get/set them byte by byte, while the virtio 1.0 spec explicitly states:
    
    	4.2.2.2 Driver Requirements: MMIO Device Register Layout
    
    	...
    
    	The driver MUST only use 32 bit wide and aligned reads and writes to
    	access the control registers described in table 4.1.
    	For the device-specific configuration space, the driver MUST use
    	8 bit wide accesses for 8 bit wide fields, 16 bit wide and aligned
    	accesses for 16 bit wide fields and 32 bit wide and aligned accesses for
    	32 and 64 bit wide fields.
    
    Borrow code from virtio_pci_modern to do this correctly.
    Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
    Signed-off-by: default avatarRusty Russell <rusty@rustcorp.com.au>
    704a0b5f
virtio_mmio.c 18.8 KB