• Arnd Bergmann's avatar
    x86/debug: Define BUG() again for !CONFIG_BUG · 70579a86
    Arnd Bergmann authored
    The latest change to the BUG() macro inadvertently reverted the earlier
    commit:
    
      b06dd879 ("x86: always define BUG() and HAVE_ARCH_BUG, even with !CONFIG_BUG")
    
    ... that sanitized the behavior with CONFIG_BUG=n.
    
    I noticed this as some warnings have appeared again that were previously
    fixed as a side effect of that patch:
    
      kernel/seccomp.c: In function '__seccomp_filter':
      kernel/seccomp.c:670:1: error: no return statement in function returning non-void [-Werror=return-type]
      ...
    
    This combines the two patches and uses the ud2 macro to define BUG()
    in case of CONFIG_BUG=n.
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Cc: Andy Lutomirski <luto@kernel.org>
    Cc: Borislav Petkov <bp@alien8.de>
    Cc: Brian Gerst <brgerst@gmail.com>
    Cc: Denys Vlasenko <dvlasenk@redhat.com>
    Cc: H. Peter Anvin <hpa@zytor.com>
    Cc: Josh Poimboeuf <jpoimboe@redhat.com>
    Cc: Josh Triplett <josh@joshtriplett.org>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Fixes: 9a93848f ("x86/debug: Implement __WARN() using UD0")
    Link: http://lkml.kernel.org/r/20170329211646.2707365-1-arnd@arndb.deSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
    70579a86
bug.h 2.18 KB