• Lukas Wunner's avatar
    driver core: Avoid binding drivers to dead devices · 706695d4
    Lukas Wunner authored
    commit 65488832 upstream.
    
    Commit 3451a495 ("driver core: Establish order of operations for
    device_add and device_del via bitflag") sought to prevent asynchronous
    driver binding to a device which is being removed.  It added a
    per-device "dead" flag which is checked in the following code paths:
    
    * asynchronous binding in __driver_attach_async_helper()
    *  synchronous binding in device_driver_attach()
    * asynchronous binding in __device_attach_async_helper()
    
    It did *not* check the flag upon:
    
    *  synchronous binding in __device_attach()
    
    However __device_attach() may also be called asynchronously from:
    
    deferred_probe_work_func()
      bus_probe_device()
        device_initial_probe()
          __device_attach()
    
    So if the commit's intention was to check the "dead" flag in all
    asynchronous code paths, then a check is also necessary in
    __device_attach().  Add the missing check.
    
    Fixes: 3451a495 ("driver core: Establish order of operations for device_add and device_del via bitflag")
    Signed-off-by: default avatarLukas Wunner <lukas@wunner.de>
    Cc: stable@vger.kernel.org # v5.1+
    Cc: Alexander Duyck <alexander.h.duyck@linux.intel.com>
    Link: https://lore.kernel.org/r/de88a23a6fe0ef70f7cfd13c8aea9ab51b4edab6.1594214103.git.lukas@wunner.deSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    706695d4
dd.c 28.1 KB