• Ronald Tschalär's avatar
    drm/bridge: sil_sii8620: make remote control optional. · 710abfe8
    Ronald Tschalär authored
    commit d6abe6df ("drm/bridge: sil_sii8620: do not have a dependency
    of RC_CORE") changed the driver to select both RC_CORE and INPUT.
    However, this causes problems with other drivers, in particular an input
    driver that depends on MFD_INTEL_LPSS_PCI (to be added in a separate
    commit):
    
      drivers/clk/Kconfig:9:error: recursive dependency detected!
      drivers/clk/Kconfig:9:        symbol COMMON_CLK is selected by MFD_INTEL_LPSS
      drivers/mfd/Kconfig:566:      symbol MFD_INTEL_LPSS is selected by MFD_INTEL_LPSS_PCI
      drivers/mfd/Kconfig:580:      symbol MFD_INTEL_LPSS_PCI is implied by KEYBOARD_APPLESPI
      drivers/input/keyboard/Kconfig:73:    symbol KEYBOARD_APPLESPI depends on INPUT
      drivers/input/Kconfig:8:      symbol INPUT is selected by DRM_SIL_SII8620
      drivers/gpu/drm/bridge/Kconfig:83:    symbol DRM_SIL_SII8620 depends on DRM_BRIDGE
      drivers/gpu/drm/bridge/Kconfig:1:     symbol DRM_BRIDGE is selected by DRM_PL111
      drivers/gpu/drm/pl111/Kconfig:1:      symbol DRM_PL111 depends on COMMON_CLK
    
    According to the docs and general consensus, select should only be used
    for non user-visible symbols, but both RC_CORE and INPUT are
    user-visible. Furthermore almost all other references to INPUT
    throughout the kernel config are depends, not selects. For this reason
    the first part of this change reverts the commit.
    
    In order to address the original reason for the commit, namely
    that not all boards use the remote controller functionality and hence
    should not need have to deal with RC_CORE, the second part of this
    change now makes the remote control support in the driver optional and
    contingent on RC_CORE being defined. And with this the hard dependency
    on INPUT also goes away as that is only needed if RC_CORE is defined
    (which in turn already depends on INPUT).
    
    CC: Inki Dae <inki.dae@samsung.com>
    CC: Andrzej Hajda <a.hajda@samsung.com>
    CC: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
    CC: Dmitry Torokhov <dmitry.torokhov@gmail.com>
    Signed-off-by: default avatarRonald Tschalär <ronald@innovation.ch>
    Reviewed-by: default avatarAndrzej Hajda <a.hajda@samsung.com>
    [a.hajda: applied fixup provided by Arnd Bergmann]
    Signed-off-by: default avatarAndrzej Hajda <a.hajda@samsung.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20190419081926.13567-2-ronald@innovation.ch
    710abfe8
Kconfig 3.9 KB