• Jacob Keller's avatar
    i40e: fix i40e_add_queue_stats data pointer update · 333e2f2c
    Jacob Keller authored
    This function accidentally failed to update the data pointer, which
    caused the reported stats to be incorrect. Additionally, statistics
    which follow queue stats in the output would potentially read non-zeroed
    garbage data from the ethtool buffer.
    
    This occurred because the data double pointer was not dereferenced
    before incrementing the size.
    
    Additionally, make sure this issue is more visible by adding a WARN_ONCE
    to the i40e_get_ethtool_stats function. This warning will trigger
    whenever the data pointer is not at the expected address, similar to the
    check that we make in the i40e_get_stat_strings() function.
    Signed-off-by: default avatarJacob Keller <jacob.e.keller@intel.com>
    Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
    Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
    333e2f2c
i40e_ethtool.c 148 KB