• Jason Andryuk's avatar
    xen-pcifront: Handle missed Connected state · 728c2edf
    Jason Andryuk authored
    An HVM guest with linux stubdomain and 2 PCI devices failed to start as
    libxl timed out waiting for the PCI devices to be added.  It happens
    intermittently but with some regularity.  libxl wrote the two xenstore
    entries for the devices, but then timed out waiting for backend state 4
    (Connected) - the state stayed at 7 (Reconfiguring).  (PCI passthrough
    to an HVM with stubdomain is PV passthrough to the stubdomain and then
    HVM passthrough with the QEMU inside the stubdomain.)
    
    The stubdomain kernel never printed "pcifront pci-0: Installing PCI
    frontend", so it seems to have missed state 4 which would have
    called pcifront_try_connect() -> pcifront_connect_and_init_dma()
    
    Have pcifront_detach_devices() special-case state Initialised and call
    pcifront_connect_and_init_dma().  Don't use pcifront_try_connect()
    because that sets the xenbus state which may throw off the backend.
    After connecting, skip the remainder of detach_devices since none have
    been initialized yet.  When the backend switches to Reconfigured,
    pcifront_attach_devices() will pick them up again.
    Signed-off-by: default avatarJason Andryuk <jandryuk@gmail.com>
    Reviewed-by: default avatarJuergen Gross <jgross@suse.com>
    Link: https://lore.kernel.org/r/20220829151536.8578-1-jandryuk@gmail.comSigned-off-by: default avatarJuergen Gross <jgross@suse.com>
    728c2edf
xen-pcifront.c 27.2 KB