• Matt Redfearn's avatar
    MIPS: Refactor handling of stack pointer in get_frame_info · 56dfb700
    Matt Redfearn authored
    Commit 34c2f668 ("MIPS: microMIPS: Add unaligned access support.")
    added handling of microMIPS instructions to manipulate the stack
    pointer. The code that was added violates code style rules with long
    lines caused by lots of nested conditionals.
    
    The added code interprets (inline) any known stack pointer manipulation
    instruction to find the stack frame size. Handling the microMIPS cases
    added quite a bit of complication to this function.
    
    Refactor is_sp_move_ins to perform the interpretation of the immediate
    as the instruction manipulating the stack pointer is found. This reduces
    the amount of indentation required in get_frame_info, and more closely
    matches the operation of is_ra_save_ins.
    Suggested-by: default avatarMaciej W. Rozycki <macro@imgtec.com>
    Signed-off-by: default avatarMatt Redfearn <matt.redfearn@imgtec.com>
    Cc: Marcin Nowakowski <marcin.nowakowski@imgtec.com>
    Cc: Ingo Molnar <mingo@kernel.org>
    Cc: Paul Burton <paul.burton@imgtec.com>
    Cc: linux-mips@linux-mips.org
    Cc: linux-kernel@vger.kernel.org
    Patchwork: https://patchwork.linux-mips.org/patch/16958/Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
    56dfb700
process.c 19.4 KB