• Qu Wenruo's avatar
    btrfs: remove the dead comment in writepage_delalloc() · 7361b4ae
    Qu Wenruo authored
    When btrfs_run_delalloc_range() failed, we will error out.
    
    But there is a strange comment mentioning that
    btrfs_run_delalloc_range() could have returned value >0 to indicate the
    IO has already started.
    
    Commit 40f76580 ("Btrfs: split up __extent_writepage to lower stack
    usage") introduced the comment, but unfortunately at that time, we were
    already using @page_started to indicate that case, and still return 0.
    
    Furthermore, even if that comment was right (which is not), we would
    return -EIO if the IO had already started.
    
    By all means the comment is incorrect, just remove the comment along
    with the dead check.
    
    Just to be extra safe, add an ASSERT() in btrfs_run_delalloc_range() to
    make sure we either return 0 or error, no positive return value.
    Signed-off-by: default avatarQu Wenruo <wqu@suse.com>
    Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
    7361b4ae
inode.c 307 KB