• Lino Sanfilippo's avatar
    net: ethernet: stmmac: remove private tx queue lock · 739c8e14
    Lino Sanfilippo authored
    The driver uses a private lock for synchronization of the xmit function and
    the xmit completion handler, but since the NETIF_F_LLTX flag is not set,
    the xmit function is also called with the xmit_lock held.
    
    On the other hand the completion handler uses the reverse locking order by
    first taking the private lock and (in case that the tx queue had been
    stopped) then the xmit_lock.
    
    Improve the locking by removing the private lock and using only the
    xmit_lock for synchronization instead.
    Signed-off-by: default avatarLino Sanfilippo <LinoSanfilippo@gmx.de>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    739c8e14
stmmac.h 4.18 KB