• Prameela Rani Garnepudi's avatar
    UBUNTU: SAUCE: Redpine: fix wowlan issue · 73f23199
    Prameela Rani Garnepudi authored
    BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1742090
    BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1742094
    
    Two issues were observed, kernel warning at S4 restore and other
    is failing to wakeup at times.
    Kernel warning is because, at hibernate resume while mac80211
    is resuming, driver is issuing mac80211 detach. The warning is
    as below:
    [  374.972073] WARNING: CPU: 1 PID: 3725 at linux-4.4.0/net/mac80211/iface.c:1000 ieee80211_do_stop+0x6ea/0x810 [mac80211]()
    ....
    [  374.972211] CPU: 1 PID: 3725 Comm: kworker/u4:44 Tainted: G        W       4.4.0-98-generic #121-Ubuntu
    [  374.972213] Hardware name: Dell Inc. Edge Gateway 3002/      , BIOS 01.00.05 11/22/2017
    [  374.972223] Workqueue: events_unbound async_run_entry_fn
    [  374.972230]  0000000000000286 bf3948ba9db4c154 ffff88005a733ad8 ffffffff813fb2c3
    [  374.972235]  0000000000000000 ffffffffc04b8ac8 ffff88005a733b10 ffffffff810812e2
    [  374.972239]  ffff8800787c0840 ffff88006f18e700 0000000000000000 ffff88006f18ee90
    [  374.972240] Call Trace:
    [  374.972249]  [<ffffffff813fb2c3>] dump_stack+0x63/0x90
    [  374.972256]  [<ffffffff810812e2>] warn_slowpath_common+0x82/0xc0
    [  374.972260]  [<ffffffff8108142a>] warn_slowpath_null+0x1a/0x20
    [  374.972305]  [<ffffffffc045915a>] ieee80211_do_stop+0x6ea/0x810 [mac80211]
    [  374.972312]  [<ffffffff818441ee>] ? _raw_spin_unlock_bh+0x1e/0x20
    [  374.972317]  [<ffffffff817608ba>] ? dev_deactivate_many+0x20a/0x240
    [  374.972359]  [<ffffffffc045929a>] ieee80211_stop+0x1a/0x20 [mac80211]
    [  374.972365]  [<ffffffff81732a39>] __dev_close_many+0x99/0x100
    [  374.972369]  [<ffffffff81732b31>] dev_close_many+0x91/0x140
    [  374.972374]  [<ffffffff810e6171>] ? synchronize_sched_expedited+0x4e1/0x880
    [  374.972379]  [<ffffffff81734e2a>] dev_close.part.79+0x4a/0x70
    [  374.972383]  [<ffffffff81734e6a>] dev_close+0x1a/0x20
    [  374.972425]  [<ffffffffc035fac1>] cfg80211_shutdown_all_interfaces+0x41/0xa0 [cfg80211]
    [  374.972467]  [<ffffffffc045a6c6>] ieee80211_remove_interfaces+0x56/0x1f0 [mac80211]
    [  374.972506]  [<ffffffffc0441bca>] ieee80211_unregister_hw+0x4a/0x120 [mac80211]
    
    This is avoided by calling ieee80211_restart_hw and reinitializing
    device as usual in sdio restore and waiting in mac80211_resume
    until device is ready.
    Other issue may be due to firmware assertion observed at times for
    the length of bgscan probe request at restore. To avoid this,
    unnecessary IEs are cut from the frame at end.
    Signed-off-by: default avatarPrameela Rani Garnepudi <prameela.j04cs@gmail.com>
    Signed-off-by: default avatarAmitkumar Karwar <amit.karwar@redpinesignals.com>
    Acked-by: default avatarKai Heng Feng <kai.heng.feng@canonical.com>
    Acked-by: default avatarShrirang Bagul <shrirang.bagul@canonical.com>
    Signed-off-by: default avatarKhalid Elmously <khalid.elmously@canonical.com>
    73f23199
rsi_common.h 4.26 KB