• Lyude Paul's avatar
    drm/nouveau: Reset MST branching unit before enabling · fa3cdf8d
    Lyude Paul authored
    When probing a new MST device, it's not safe to make any assumptions
    about it's current state. While most well mannered MST hubs will just
    disable the branching unit on hotplug disconnects, this isn't enough to
    save us from various other scenarios that might have resulted in
    something writing to the MST branching unit before we got control of it.
    This could happen if a previous probe we tried failed, if we're booting
    in kexec context and the hub is still in the state the last kernel put
    it in, etc.
    
    Luckily; there is no reason we can't just reset the branching unit
    every time we enable a new topology. So, fix this by resetting it on
    enabling new topologies to ensure that we always start off with a clean,
    unmodified topology state on MST sinks.
    
    This fixes occasional hard-lockups on my P50's laptop dock (e.g. AUX
    times out all DPCD trasactions) observed after multiple docks, undocks,
    and module reloads.
    Signed-off-by: default avatarLyude Paul <lyude@redhat.com>
    Cc: stable@vger.kernel.org
    Cc: Karol Herbst <karolherbst@gmail.com>
    Signed-off-by: default avatarBen Skeggs <bskeggs@redhat.com>
    fa3cdf8d
disp.c 60 KB