• Changbin Du's avatar
    perf ftrace: Detect whether ftrace is enabled on system · 74298dd8
    Changbin Du authored
    To make error messages more accurate, this change detects whether ftrace is
    enabled on system by checking trace file "set_ftrace_pid".
    
    Before:
    
      # perf ftrace
      failed to reset ftrace
      #
    
    After:
    
      # perf ftrace
      ftrace is not supported on this system
      #
    
    Committer testing:
    
    Doing it in an unprivileged toolbox container on Fedora 40:
    
    Before:
    
      acme@number:~/git/perf-tools-next$ toolbox enter perf
      ⬢[acme@toolbox perf-tools-next]$ sudo su -
      ⬢[root@toolbox ~]# ~acme/bin/perf ftrace
      failed to reset ftrace
      ⬢[root@toolbox ~]#
    
    After this patch:
    
      ⬢[root@toolbox ~]# ~acme/bin/perf ftrace
      ftrace is not supported on this system
      ⬢[root@toolbox ~]#
    
    Maybe we could check if we are in such as situation, inside an
    unprivileged container, and provide a HINT line?
    Reviewed-by: default avatarJames Clark <james.clark@linaro.org>
    Signed-off-by: default avatarChangbin Du <changbin.du@huawei.com>
    Tested-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    Cc: Adrian Hunter <adrian.hunter@intel.com>
    Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
    Cc: Changbin Du <changbin.du@huawei.com>
    Cc: Ian Rogers <irogers@google.com>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: Kan Liang <kan.liang@linux.intel.com>
    Cc: Mark Rutland <mark.rutland@arm.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Link: https://lore.kernel.org/r/20240911100126.900779-1-changbin.du@huawei.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    74298dd8
builtin-ftrace.c 38 KB