• Liu Ying's avatar
    drm/bridge: synopsys: dw-mipi-dsi: Disable HSTX and LPRX timeout check · 743bf594
    Liu Ying authored
    According to Synopsys DW MIPI DSI host databook, HSTX and LPRX timeout
    contention detections are measured in TO_CLK_DIVISION cycles.  However,
    the current driver programs magic values to TO_CLK_DIVISION, HSTX_TO_CNT
    and LPRX_TO_CNT register fields, which makes timeout error event wrongly
    happen for some video modes, at least for the typical 1920x1080p@60 video
    mode read from a HDMI monitor driven by ADV7535 DSI to HDMI bridge.
    While at it, the current driver doesn't enable interrupt to handle or
    complain about the error status, so true error just happens silently
    except for display distortions by visual check.
    
    Disable the timeout check by setting those timeout register fields to
    zero for now until someone comes along with better computations for the
    timeout values.  Although the databook doesn't mention what happens when
    they are set to zero, it turns out the false error doesn't happen for
    the 1920x1080p@60 video mode at least.
    Signed-off-by: default avatarLiu Ying <victor.liu@nxp.com>
    Reviewed-by: default avatarNeil Armstrong <neil.armstrong@linaro.org>
    Signed-off-by: default avatarRobert Foss <rfoss@kernel.org>
    Link: https://patchwork.freedesktop.org/patch/msgid/20230821034008.3876938-8-victor.liu@nxp.com
    743bf594
dw-mipi-dsi.c 34.4 KB