• Claire Jensen's avatar
    perf test: Add checking for perf stat CSV output. · 7473ee56
    Claire Jensen authored
    Counts expected fields for various commands. No testing added for
    summary mode since it is broken.
    
    An example of the summary output is:
    
             summary,263831,,instructions:u,1435072,100.0,0.46,insn per cycle
    ,,,,,1.37,stalled cycles per insn
    
    This should be:
    
             summary,263831,,instructions:u,1435072,100.0,0.46,insn per cycle
             summary,,,,,,1.37,stalled cycles per insn
    
    The output has 7 fields when it should have 8. Additionally, the newline
    spacing is wrong, so it was excluded from testing until a fix is made.
    
    Committer testing:
    
      $ perf test "perf stat CSV output"
       88: perf stat CSV output linter                                     : Ok
      $
    
      $ perf test -v "perf stat CSV output"
      Couldn't bump rlimit(MEMLOCK), failures may take place when creating BPF maps, etc
       88: perf stat CSV output linter                                     :
      --- start ---
      test child forked, pid 2622839
      Checking CSV output: no args [Success]
      Checking CSV output: system wide [Skip] paranoid and not root
      Checking CSV output: system wide [Skip] paranoid and not root
      Checking CSV output: interval [Success]
      Checking CSV output: event [Success]
      Checking CSV output: per core [Skip] paranoid and not root
      Checking CSV output: per thread [Skip] paranoid and not root
      Checking CSV output: per die [Skip] paranoid and not root
      Checking CSV output: per node [Skip] paranoid and not root
      Checking CSV output: per socket [Skip] paranoid and not root
      test child finished with 0
      ---- end ----
      perf stat CSV output linter: Ok
      $
    
    I did a s/parnoia/paranoid/g on the [Skip] lines.
    Signed-off-by: default avatarClaire Jensen <cjense@google.com>
    Tested-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
    Cc: Alyssa Ross <hi@alyssa.is>
    Cc: Claire Jensen <clairej735@gmail.com>
    Cc: Florian Fischer <florian.fischer@muhq.space>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: James Clark <james.clark@arm.com>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: Kan Liang <kan.liang@linux.intel.com>
    Cc: Like Xu <likexu@tencent.com>
    Cc: Mark Rutland <mark.rutland@arm.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Sandipan Das <sandipan.das@amd.com>
    Cc: Stephane Eranian <eranian@google.com>
    Cc: Xing Zhengjun <zhengjun.xing@linux.intel.com>
    Link: https://lore.kernel.org/r/20220525053814.3265216-2-irogers@google.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    7473ee56
perf_csv_output_lint.py 1.58 KB