• Wang Nan's avatar
    perf test: Fix false TEST_OK result for 'perf test hist' · 71b3ee7e
    Wang Nan authored
    Commit 71d6de64 ("perf test: Fix hist testcases when kptr_restrict is on")
    solves a double free problem when 'perf test hist' calling
    setup_fake_machine(). However, the result is still incorrect. For example:
    
      $ ./perf test -v 'filtering hist entries'
      25: Test filtering hist entries                              :
      --- start ---
      test child forked, pid 4186
      Cannot create kernel maps
      test child finished with 0
      ---- end ----
      Test filtering hist entries: Ok
    
    In this case the body of this test is not get executed at all, but the
    result is 'Ok'.
    
    Actually, in setup_fake_machine() there's no need to create real kernel
    maps. What we want are the fake maps. This patch removes the
    machine__create_kernel_maps() in setup_fake_machine(), so it won't be
    affected by kptr_restrict setting.
    
    Test result:
    
      $ cat /proc/sys/kernel/kptr_restrict
      1
      $ ~/perf test -v hist
      15: Test matching and linking multiple hists                 :
      --- start ---
      test child forked, pid 24031
      test child finished with 0
      ---- end ----
      Test matching and linking multiple hists: Ok
      [SNIP]
    Suggested-and-Acked-by: default avatarNamhyung Kim <namhyung@kernel.org>
    Signed-off-by: default avatarWang Nan <wangnan0@huawei.com>
    Tested-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
    Cc: Zefan Li <lizefan@huawei.com>
    Cc: pi3orama@163.com
    Link: http://lkml.kernel.org/r/1452520124-2073-12-git-send-email-wangnan0@huawei.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    71b3ee7e
hists_common.c 4.94 KB