• Jeff Moyer's avatar
    mtip32x: fix regression introduced by blk-mq per-hctx flush · 74c9c913
    Jeff Moyer authored
    Hi,
    
    After commit f70ced09 (blk-mq: support per-distpatch_queue flush
    machinery), the mtip32xx driver may oops upon module load due to walking
    off the end of an array in mtip_init_cmd.  On initialization of the
    flush_rq, init_request is called with request_index >= the maximum queue
    depth the driver supports.  For mtip32xx, this value is used to index
    into an array.  What this means is that the driver will walk off the end
    of the array, and either oops or cause random memory corruption.
    
    The problem is easily reproduced by doing modprobe/rmmod of the mtip32xx
    driver in a loop.  I can typically reproduce the problem in about 30
    seconds.
    
    Now, in the case of mtip32xx, it actually doesn't support flush/fua, so
    I think we can simply return without doing anything.  In addition, no
    other mq-enabled driver does anything with the request_index passed into
    init_request(), so no other driver is affected.  However, I'm not really
    sure what is expected of drivers.  Ming, what did you envision drivers
    would do when initializing the flush requests?
    Signed-off-by: default avatarJeff Moyer <jmoyer@redhat.com>
    Signed-off-by: default avatarJens Axboe <axboe@fb.com>
    74c9c913
mtip32xx.c 114 KB