• Miklos Szeredi's avatar
    fuse: fix use after free in fuse_read_interrupt() · e1e71c16
    Miklos Szeredi authored
    There is a potential race between fuse_read_interrupt() and
    fuse_request_end().
    
    TASK1
      in fuse_read_interrupt(): delete req->intr_entry (while holding
      fiq->lock)
    
    TASK2
      in fuse_request_end(): req->intr_entry is empty -> skip fiq->lock
      wake up TASK3
    
    TASK3
      request is freed
    
    TASK1
      in fuse_read_interrupt(): dereference req->in.h.unique ***BAM***
    
    
    Fix by always grabbing fiq->lock if the request was ever interrupted
    (FR_INTERRUPTED set) thereby serializing with concurrent
    fuse_read_interrupt() calls.
    
    FR_INTERRUPTED is set before the request is queued on fiq->interrupts.
    Dequeing the request is done with list_del_init() but FR_INTERRUPTED is not
    cleared in this case.
    Reported-by: default avatarlijiazi <lijiazi@xiaomi.com>
    Signed-off-by: default avatarMiklos Szeredi <mszeredi@redhat.com>
    e1e71c16
dev.c 51.9 KB