• Johan Hovold's avatar
    serial: do not restore interrupt state in sysrq helper · 75f4e830
    Johan Hovold authored
    The uart_unlock_and_check_sysrq() helper can be used to defer processing
    of sysrq until the interrupt handler has released the port lock and is
    about to return.
    
    Since commit 81e2073c ("genirq: Disable interrupts for force
    threaded handlers") interrupt handlers that are not explicitly requested
    as threaded are always called with interrupts disabled and there is no
    need to save the interrupt state when taking the port lock.
    
    Instead of adding another sysrq helper for when the interrupt state has
    not needlessly been saved, drop the state parameter from
    uart_unlock_and_check_sysrq() and update its callers to no longer
    explicitly disable interrupts in their interrupt handlers.
    
    Cc: Joel Stanley <joel@jms.id.au>
    Cc: Andrew Jeffery <andrew@aj.id.au>
    Cc: Andy Gross <agross@kernel.org>
    Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
    Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
    Link: https://lore.kernel.org/r/20210416140557.25177-2-johan@kernel.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    75f4e830
8250_port.c 84.9 KB