• Jiri Slaby (SUSE)'s avatar
    bonding (gcc13): synchronize bond_{a,t}lb_xmit() types · 777fa87c
    Jiri Slaby (SUSE) authored
    Both bond_alb_xmit() and bond_tlb_xmit() produce a valid warning with
    gcc-13:
      drivers/net/bonding/bond_alb.c:1409:13: error: conflicting types for 'bond_tlb_xmit' due to enum/integer mismatch; have 'netdev_tx_t(struct sk_buff *, struct net_device *)' ...
      include/net/bond_alb.h:160:5: note: previous declaration of 'bond_tlb_xmit' with type 'int(struct sk_buff *, struct net_device *)'
    
      drivers/net/bonding/bond_alb.c:1523:13: error: conflicting types for 'bond_alb_xmit' due to enum/integer mismatch; have 'netdev_tx_t(struct sk_buff *, struct net_device *)' ...
      include/net/bond_alb.h:159:5: note: previous declaration of 'bond_alb_xmit' with type 'int(struct sk_buff *, struct net_device *)'
    
    I.e. the return type of the declaration is int, while the definitions
    spell netdev_tx_t. Synchronize both of them to the latter.
    
    Cc: Martin Liska <mliska@suse.cz>
    Cc: Jay Vosburgh <j.vosburgh@gmail.com>
    Cc: Veaceslav Falico <vfalico@gmail.com>
    Cc: Andy Gospodarek <andy@greyhouse.net>
    Signed-off-by: default avatarJiri Slaby (SUSE) <jirislaby@kernel.org>
    Link: https://lore.kernel.org/r/20221031114409.10417-1-jirislaby@kernel.orgSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
    777fa87c
bond_alb.h 6.1 KB