• Arnd Bergmann's avatar
    soc: fsl: dpio: fix kcalloc() argument order · 72ebb41b
    Arnd Bergmann authored
    A previous bugfix added a call to kcalloc(), which starting in gcc-14
    causes a harmless warning about the argument order:
    
    drivers/soc/fsl/dpio/dpio-service.c: In function 'dpaa2_io_service_enqueue_multiple_desc_fq':
    drivers/soc/fsl/dpio/dpio-service.c:526:29: error: 'kcalloc' sizes specified with 'sizeof' in the earlier argument and not in the later argument [-Werror=calloc-transposed-args]
      526 |         ed = kcalloc(sizeof(struct qbman_eq_desc), 32, GFP_KERNEL);
          |                             ^~~~~~
    drivers/soc/fsl/dpio/dpio-service.c:526:29: note: earlier argument should specify number of elements, later size of each element
    
    Since the two are only multiplied, the order does not change the
    behavior, so just fix it now to shut up the compiler warning.
    
    Dmity independently came up with the same fix.
    
    Fixes: 5c4a5999 ("soc: fsl: dpio: avoid stack usage warning")
    Reported-by: default avatarDmitry Antipov <dmantipov@yandex.ru>
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    72ebb41b
dpio-service.c 24 KB