• Thomas Gleixner's avatar
    x86/apic/32: Decrapify the def_bigsmp mechanism · 79c9a17c
    Thomas Gleixner authored
    If the system has more than 8 CPUs then XAPIC and the bigsmp APIC driver is
    required. This is ensured via:
    
      1) Enumerating all possible CPUs up to NR_CPUS
    
      2) Checking at boot CPU APIC setup time whether the system has more than
         8 CPUs and has an XAPIC.
    
         If that's the case then it's attempted to install the bigsmp APIC
         driver and a magic variable 'def_to_bigsmp' is set to one.
    
      3) If that magic variable is set and CONFIG_X86_BIGSMP=n and the system
         has more than 8 CPUs smp_sanity_check() removes all CPUs >= #8 from
         the present and possible mask in the most convoluted way.
    
    This logic is completely broken for the case where the bigsmp driver is
    enabled, but not selected due to a command line option specifying the
    default APIC. In that case the system boots with default APIC in logical
    destination mode and fails to reduce the number of CPUs.
    
    That aside the above which is sprinkled over 3 different places is yet
    another piece of art.
    
    It would have been too obvious to check the requirements upfront and limit
    nr_cpu_ids _before_ enumerating tons of CPUs and then removing them again.
    
    Implement exactly this. Check the bigsmp requirement when the boot APIC is
    registered which happens _before_ ACPI/MPTABLE parsing and limit the number
    of CPUs to 8 if it can't be used. Switch it over when the boot CPU apic is
    set up if necessary.
    
    [ dhansen: fix nr_cpu_ids off-by-one in default_setup_apic_routing() ]
    Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
    Signed-off-by: default avatarDave Hansen <dave.hansen@linux.intel.com>
    Acked-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
    Tested-by: default avatarMichael Kelley <mikelley@microsoft.com>
    Tested-by: default avatarSohil Mehta <sohil.mehta@intel.com>
    Tested-by: Juergen Gross <jgross@suse.com> # Xen PV (dom0 and unpriv. guest)
    79c9a17c
apic.c 72.1 KB