• Eric Dumazet's avatar
    tcp: ECN blackhole should not force quickack mode · 7a269ffa
    Eric Dumazet authored
    While playing with a new ADSL box at home, I discovered that ECN
    blackhole can trigger suboptimal quickack mode on linux : We send one
    ACK for each incoming data frame, without any delay and eventual
    piggyback.
    
    This is because TCP_ECN_check_ce() considers that if no ECT is seen on a
    segment, this is because this segment was a retransmit.
    
    Refine this heuristic and apply it only if we seen ECT in a previous
    segment, to detect ECN blackhole at IP level.
    Signed-off-by: default avatarEric Dumazet <eric.dumazet@gmail.com>
    CC: Jamal Hadi Salim <jhs@mojatatu.com>
    CC: Jerry Chu <hkchu@google.com>
    CC: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
    CC: Jim Gettys <jg@freedesktop.org>
    CC: Dave Taht <dave.taht@gmail.com>
    Acked-by: default avatarIlpo Järvinen <ilpo.jarvinen@helsinki.fi>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    7a269ffa
tcp_input.c 170 KB