• Namhyung Kim's avatar
    perf annotate-data: Show offset and size in hex · 7a5c2170
    Namhyung Kim authored
    It'd be better to have them in hex to check cacheline alignment.
    
     Percent     offset       size  field
      100.00          0      0x1c0  struct cfs_rq    {
        0.00          0       0x10      struct load_weight  load {
        0.00          0        0x8          long unsigned int       weight;
        0.00        0x8        0x4          u32     inv_weight;
                                        };
        0.00       0x10        0x4      unsigned int        nr_running;
       14.56       0x14        0x4      unsigned int        h_nr_running;
        0.00       0x18        0x4      unsigned int        idle_nr_running;
        0.00       0x1c        0x4      unsigned int        idle_h_nr_running;
      ...
    
    Committer notes:
    
    Justification from Namhyung when asked about why it would be "better":
    
    Cache line sizes are power of 2 so it'd be natural to use hex and
    check whether an offset is in the same boundary.  Also 'perf annotate'
    shows instruction offsets in hex.
    
    >
    > Maybe this should be selectable?
    
    I can add an option and/or a config if you want.
    Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
    Tested-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    Cc: Adrian Hunter <adrian.hunter@intel.com>
    Cc: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
    Cc: Ian Rogers <irogers@google.com>
    Cc: Ingo Molnar <mingo@kernel.org>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: Kan Liang <kan.liang@linux.intel.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Link: https://lore.kernel.org/r/20240819233603.54941-1-namhyung@kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    7a5c2170
sort.c 96 KB