• Marc Kleine-Budde's avatar
    can: netlink: allow configuring of fixed bit rates without need for do_set_bittiming callback · 7e193a42
    Marc Kleine-Budde authored
    Usually CAN devices support configurable bit rates. The limits are
    defined by struct can_priv::bittiming_const. Another way is to
    implement the struct can_priv::do_set_bittiming callback.
    
    If the bit rate is configured via netlink, the can_changelink()
    function checks that either can_priv::bittiming_const or struct
    can_priv::do_set_bittiming is implemented.
    
    In commit 431af779 ("can: dev: add CAN interface API for fixed
    bitrates") an API for configuring bit rates on CAN interfaces that
    only support fixed bit rates was added. The supported bit rates are
    defined by struct can_priv::bitrate_const.
    
    However the above mentioned commit forgot to add the struct
    can_priv::bitrate_const to the check in can_changelink().
    
    In order to avoid to implement a no-op can_priv::do_set_bittiming
    callback on devices with fixed bit rates, extend the check in
    can_changelink() accordingly.
    
    Link: https://lore.kernel.org/all/20220611144248.3924903-1-mkl@pengutronix.de
    Fixes: 431af779 ("can: dev: add CAN interface API for fixed bitrates")
    Reported-by: default avatarMax Staudt <max@enpas.org>
    Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
    7e193a42
netlink.c 17.8 KB