• Leo Yan's avatar
    perf symbols: Consolidate symbol fixup issue · 7eec00a7
    Leo Yan authored
    After copying Arm64's perf archive with object files and perf.data file
    to x86 laptop, the x86's perf kernel symbol resolution fails.  It
    outputs 'unknown' for all symbols parsing.
    
    This issue is root caused by the function elf__needs_adjust_symbols(),
    x86 perf tool uses one weak version, Arm64 (and powerpc) has rewritten
    their own version.  elf__needs_adjust_symbols() decides if need to parse
    symbols with the relative offset address; but x86 building uses the weak
    function which misses to check for the elf type 'ET_DYN', so that it
    cannot parse symbols in Arm DSOs due to the wrong result from
    elf__needs_adjust_symbols().
    
    The DSO parsing should not depend on any specific architecture perf
    building; e.g. x86 perf tool can parse Arm and Arm64 DSOs, vice versa.
    And confirmed by Naveen N. Rao that powerpc64 kernels are not being
    built as ET_DYN anymore and change to ET_EXEC.
    
    This patch removes the arch specific functions for Arm64 and powerpc and
    changes elf__needs_adjust_symbols() as a common function.
    
    In the common elf__needs_adjust_symbols(), it checks an extra condition
    'ET_DYN' for elf header type.  With this fixing, the Arm64 DSO can be
    parsed properly with x86's perf tool.
    
    Before:
    
      # perf script
      main 3258 1 branches:                0 [unknown] ([unknown]) => ffff800010c4665c [unknown] ([kernel.kallsyms])
      main 3258 1 branches: ffff800010c46670 [unknown] ([kernel.kallsyms]) => ffff800010c4eaec [unknown] ([kernel.kallsyms])
      main 3258 1 branches: ffff800010c4eaec [unknown] ([kernel.kallsyms]) => ffff800010c4eb00 [unknown] ([kernel.kallsyms])
      main 3258 1 branches: ffff800010c4eb08 [unknown] ([kernel.kallsyms]) => ffff800010c4e780 [unknown] ([kernel.kallsyms])
      main 3258 1 branches: ffff800010c4e7a0 [unknown] ([kernel.kallsyms]) => ffff800010c4eeac [unknown] ([kernel.kallsyms])
      main 3258 1 branches: ffff800010c4eebc [unknown] ([kernel.kallsyms]) => ffff800010c4ed80 [unknown] ([kernel.kallsyms])
    
    After:
    
      # perf script
      main 3258 1 branches:                0 [unknown] ([unknown]) => ffff800010c4665c coresight_timeout+0x54 ([kernel.kallsyms])
      main 3258 1 branches: ffff800010c46670 coresight_timeout+0x68 ([kernel.kallsyms]) => ffff800010c4eaec etm4_enable_hw+0x3cc ([kernel.kallsyms])
      main 3258 1 branches: ffff800010c4eaec etm4_enable_hw+0x3cc ([kernel.kallsyms]) => ffff800010c4eb00 etm4_enable_hw+0x3e0 ([kernel.kallsyms])
      main 3258 1 branches: ffff800010c4eb08 etm4_enable_hw+0x3e8 ([kernel.kallsyms]) => ffff800010c4e780 etm4_enable_hw+0x60 ([kernel.kallsyms])
      main 3258 1 branches: ffff800010c4e7a0 etm4_enable_hw+0x80 ([kernel.kallsyms]) => ffff800010c4eeac etm4_enable+0x2d4 ([kernel.kallsyms])
      main 3258 1 branches: ffff800010c4eebc etm4_enable+0x2e4 ([kernel.kallsyms]) => ffff800010c4ed80 etm4_enable+0x1a8 ([kernel.kallsyms])
    
    v3: Changed to check for ET_DYN across all architectures.
    
    v2: Fixed Arm64 and powerpc native building.
    Reported-by: default avatarMike Leach <mike.leach@linaro.org>
    Signed-off-by: default avatarLeo Yan <leo.yan@linaro.org>
    Reviewed-by: default avatarNaveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
    Acked-by: default avatarJiri Olsa <jolsa@redhat.com>
    Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
    Cc: Allison Randal <allison@lohutok.net>
    Cc: Enrico Weigelt <info@metux.net>
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Cc: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
    Cc: John Garry <john.garry@huawei.com>
    Cc: Kate Stewart <kstewart@linuxfoundation.org>
    Cc: Mark Rutland <mark.rutland@arm.com>
    Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: Thomas Richter <tmricht@linux.vnet.ibm.com>
    Link: http://lore.kernel.org/lkml/20200306015759.10084-1-leo.yan@linaro.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    7eec00a7
Build 268 Bytes